-
Notifications
You must be signed in to change notification settings - Fork 4
Migrate build process to PEP 621/517 compliance #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hey this is awesome stuff @mg-twentyone! Are you on our Discord server for BDK? If so please send me a DM! |
hey @thunderbiscuit. I noticed a bug with the new configuration (project.toml) using setuptools-rust to include the Rust library. I am working to fix it. I will also try to update the workflow in the GitHub Actions by updating the build process for different operating systems. I joined the Discord channel, feel free to reach to me whenever you want. I will get in touch with you as soon as I finish it to provide u with all the details and simplify the review process. |
I have tested this and it works flawlessly. I'm impressed! Big update. I'd love to leave time for @reez to take a look, and maybe one of our production users to also take a look if he has time (@andreasgriffin). Overall I think this is a major improvement! A few questions are left for me, particularly regarding the naming of the wheels (this is not new and not related to this PR so I don't think of it as a blocker though). But it just feels like the whole "you have to name your artifact with the correct string otherwise pip will not consider it valid for a given platform" (instead of leveraging package metadata) is super weird and cannot possibly be optimal. Anywa this is probably for a follow-up issue or PR because it's a long-standing issue with how we build and release this library. It works, but... yeah. While we wait for review, 2 little things you can do @mg-twentyone:
|
Description
This PR updates the packaging and build system of
bdkpython
to align with modern Python packaging standards viapyproject.toml
.Changes:
Fixes #12
Changelog notice
This pull request breaks the current building wheel process
Bugfixes: