Skip to content

Conversation

@mg-twentyone
Copy link
Contributor

Description

The PR adds bdkpython API docs deployment to Github Pages.

Fixes #23

Notes to the reviewers

TODO (for repo owner)
Ensure to enable GitHub Pages Build and deployment on repo.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

Copy link
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep my understanding is that this should run through without problem!

Would you mind squashing these 3 commits into 1? Then this one is ready to go.

Copy link
Collaborator

@reez reez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK f72c4c3

Thanks again!

Copy link
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK f72c4c3.

@thunderbiscuit thunderbiscuit merged commit f72c4c3 into bitcoindevkit:master Nov 20, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto-Publish Docs to GitHub Pages

3 participants