Skip to content

(draft) ci: init bdk-ffi submodule enable ci checkout #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 23, 2025
Merged

(draft) ci: init bdk-ffi submodule enable ci checkout #7

merged 3 commits into from
Jul 23, 2025

Conversation

reez
Copy link
Collaborator

@reez reez commented Jul 23, 2025 •
edited
Loading

Description

WIP

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@reez reez requested a review from thunderbiscuit as a code owner July 23, 2025 16:01
@reez reez changed the title ci: init bdk-ffi submodule enable ci checkout (draft) ci: init bdk-ffi submodule enable ci checkout Jul 23, 2025
@reez
Copy link
Collaborator Author

reez commented Jul 23, 2025

Screenshot 2025-07-23 at 11 50 49 AM all tests pass finally

still discussion to be had about changes in PR, but happy to have gotten it working at the moment

thunderbiscuit
thunderbiscuit approved these changes Jul 23, 2025
View reviewed changes
Copy link
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d7c29e5.

@thunderbiscuit thunderbiscuit merged commit 80dd3e1 into bitcoindevkit:master Jul 23, 2025
17 checks passed
@reez reez deleted the submod branch July 23, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thunderbiscuit thunderbiscuit thunderbiscuit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reez @thunderbiscuit