Bdkwallet2

[matthiasdebernardini]

No description provided.

[Copilot]

Pull Request Overview

Introduces schema versioning and SPK cache support for Postgres, renames backup helpers, and updates examples and tooling for regtest workflows.

• Adds migrations and runtime logic to handle new last_evicted/first_seen columns and a keychain_spk table in Postgres.
• Renames easy_backup to _easy_backup in SQLite and Postgres modules to suppress unused warnings.
• Updates the Electrum example, Dockerfiles, and Justfile for streamlined setup and regtest execution.

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/sqlite.rs	Changed public easy_backup to _easy_backup
src/postgres.rs	Implemented schema version checks, added migrations, and SPK load/persist logic
migrations/postgres/01_bdk_wallet.sql	Added UNIQUE constraints, new keychain_spk table, and last_* columns
examples/bdk_sqlx_postgres.rs	Simplified full_scan usage, added anyhow::Context, updated imports
electrs.toml, electrs.Dockerfile	Electrs configuration and Docker setup
bitcoin.Dockerfile	Bitcoin Core Dockerfile for regtest
Justfile	Tasks for network setup, containers, and example execution
Cargo.toml	Bumped bdk_wallet to 2.0.0, moved bdk_electrum to dev-dependencies

Comments suppressed due to low confidence (6)

src/sqlite.rs:474

• Renaming the public function easy_backup to _easy_backup breaks the public API and can confuse users. Consider making it private (remove pub) or use #[doc(hidden)] if you intend to hide it from documentation.

pub async fn _easy_backup(db: Pool<Sqlite>) -> Result<(), BdkSqlxError> {

src/postgres.rs:627

• Using println! for diagnostics in library code will clutter stdout and bypass structured logging. Switch to a tracing::debug! or similar logging macro for consistency.

println!("load_keychain_spks: Starting for wallet '{}', descriptor_id: {:?}", wallet_name, descriptor_id);

src/postgres.rs:337

• [nitpick] The keychain_spk migration is duplicated in both the v1→v2 and v2→v3 branches. Refactor into a single conditional or rely on IF NOT EXISTS in one place to reduce code duplication.

sqlx::query(r#"CREATE TABLE IF NOT EXISTS "bdk_wallet"."keychain_spk" ... )

examples/bdk_sqlx_postgres.rs:129

• STOP_GAP and BATCH_SIZE are not imported or defined in this scope, resulting in a compile error. Import these constants or replace them (e.g., use DEFAULT_LOOKAHEAD).

let res = client.full_scan::<_>(request, STOP_GAP, BATCH_SIZE, true)

src/postgres.rs:518

• The new SPK cache persist/load logic is critical and currently untested. Add unit or integration tests covering load_keychain_spks and persist_keychain_spks to ensure correct behavior.

// Persist SPK cache

examples/bdk_sqlx_postgres.rs:7

• [nitpick] DEFAULT_LOOKAHEAD is imported but never used. Either remove the unused import or leverage it in place of the undefined STOP_GAP constant.

use bdk_wallet::bitcoin::{constants, Network};