Skip to content

refactor(wallet): Reuse chain position instead of obtaining new one #1758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jirijakes wants to merge 1 commit into from
Closed

refactor(wallet): Reuse chain position instead of obtaining new one #1758

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions crates/wallet/src/wallet/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1996,7 +1996,6 @@ impl Wallet {
let must_only_use_confirmed_tx = bumping_fee.is_some();
let must_use_all_available = *drain_wallet;

let chain_tip = self.chain.tip().block_id();
// must_spend <- manually selected utxos
// may_spend <- all other available utxos
let mut may_spend = self.get_available_utxos();
Expand All @@ -2022,17 +2021,10 @@ impl Wallet {
Some(tx) => tx,
None => return false,
};
let chain_position = match self.indexed_graph.graph().get_chain_position(
&self.chain,
chain_tip,
txid,
) {
Some(chain_position) => chain_position.cloned(),
None => return false,
};

// Whether the UTXO is mature and, if needed, confirmed
let mut spendable = true;
let chain_position = u.0.chain_position;
if must_only_use_confirmed_tx && !chain_position.is_confirmed() {
return false;
}
Expand Down
Loading