Skip to content

Conversation

@Einliterflasche
Copy link

@Einliterflasche Einliterflasche commented Dec 9, 2024

Description

This PR bumps the chain crates feature dependency on rusqlite to the more recent version 0.32.

Notes to the reviewers

I omitted the patch version because all versions 0.32.x must be compatible per the semver spec.

I submitted this PR because the "outdated" dependency breaks dependency resolution in my project.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@oleonardolima
Copy link
Contributor

Thanks for taking on this! It's failing on CI, it'd need to pin some dependencies on MSRV step (e.g. cc, libsqlite3-sys). Also, we use the https://www.conventionalcommits.org/en/v1.0.0/ on the commit message, you'd need to update the current commit one :)

@Einliterflasche Einliterflasche changed the title chor(bdk_chain): bump rusqlite dependency from 0.31.0 to 0.32 chore(bdk_chain): bump rusqlite dependency from 0.31.0 to 0.32 Dec 10, 2024
@Einliterflasche
Copy link
Author

Unfortunately the new rusqlite version uses C literals (c"foo") which have only been introduced in 1.77. This leads to the following error message:

error: prefix `c` is unknown
    --> /Users/me/.cargo/registry/src/github.com-1ecc6299db9ec823/rusqlite-0.32.1/src/lib.rs:1934:44
     |
1934 |         let r = unsafe { ffi::sqlite3_open(c":memory:".as_ptr(), &mut handle) };
     |                                            ^ unknown prefix`

In short, this upgrade would break compatiblitily with 1.63 which is the current MSRV.

@notmandatory notmandatory moved this to In Progress in BDK Chain Apr 23, 2025
@binarybaron
Copy link

@oleonardolima Any update on this? :( We use another library (arti-client) that depends on the new rusqlite version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file module-database

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

4 participants