refactor(wallet): cleanup and remove unused code in create_tx #1768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
All tests still pass after doing this? |
notmandatory
force-pushed
the
refactor/cleanup_create_tx
branch
from
a0ba177 to
cc90507
Compare
|
Re-based and fixed |
ValuedMammal
force-pushed
the
refactor/cleanup_create_tx
branch
from
cc90507 to
a2f7a8b
Compare
ValuedMammal
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cleanup and remove unused code in
Wallet::create_tx, this was noticed during review of #1763. See: #1763 (comment)fixes #1710
Notes to the reviewers
In addition to removing the unneeded assignments to
fee_amountandreceivedI also refactored creation of the change output to be anif letinstead ofmatchstatement since it only needs to do something if there isExcess::Change.I should have done this cleanup as part of #1048.
Changelog notice
None, only internal cleanup.
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing