deps(bdk_testenv): bump `electrsd` to `0.36.1` #1826

oleonardolima · 2025-02-06T20:23:34Z

partially addresses #1949

Description

It upgrades the electrsd version from 0.28.0 to 0.36.1, migrating from old bitcoind to corepc-node and using the corepc-node_28_2 feature.

Updates the bitcoind client type for TestEnv, and its internal methods. Also, updates: bdk_bitcoind_rpc, bdk_esplora, bdk_electrum usage of bdk_testenv and TestEnv.

Notes to the reviewers

As we are upgrading to the latest electrsd, we can drop for now the pinning for home in the MSRV step.

Also for both list_unspent and get_raw_transaction_verbose corepc-client APIs didn't support some required arguments in some of the tests. That said, I implemented our own RPC calls as two new methods in TestEnv.

Changelog notice

TBD

Checklists

All Submissions:

I've signed all my commits
I followed the contribution guidelines
I ran cargo fmt and cargo clippy before committing

New Features:

I've added tests for the new feature
I've added docs for the new feature

oleonardolima · 2025-02-07T14:36:05Z

It looks like I'll need to open a PR on corepc-client to add get-block-template RPC, then I'll get back to this one :(

I'll do the same in rust-electrum-client for the tests, but I'll do it to 0.30.x instead to prevent this issue from blocking the PR there.

ValuedMammal · 2025-07-21T23:20:42Z

@oleonardolima I noticed that the getblocktemplate RPC is implemented in corepc-client.

oleonardolima · 2025-07-22T13:22:47Z

@oleonardolima I noticed that the getblocktemplate RPC is implemented in corepc-client.

Yes, it was added a few releases after I started this PR, but IIRC some other methods were missing too. I'll check that again.

ValuedMammal · 2025-07-23T21:18:44Z

Yes, it was added a few releases after I started this PR, but IIRC some other methods were missing too. I'll check that again.

Seems to be lacking good support for get_raw_mempool_verbose, at least for versions of Bitcoin Core later than 0.17.

oleonardolima · 2025-07-24T15:51:29Z

Once #1988 lands, we won't be relying on get_raw_mempool_verbose; instead, we will use get_raw_mempool. It should unblock this one.

oleonardolima · 2025-08-05T02:24:49Z

Once #1988 lands, we won't be relying on get_raw_mempool_verbose; instead, we will use get_raw_mempool. It should unblock this one.

It appears that other methods are missing in the corepc-client at electrsd 0.34. They're released on corepc-node 0.8, which will be included in the next release of electrsd. Will check if there are alternative methods for those.

oleonardolima · 2025-08-08T20:15:11Z

It appears that other methods are missing in the corepc-client at electrsd 0.34. They're released on corepc-node 0.8, which will be included in the next release of electrsd. Will check if there are alternative methods for those.

As of the latest v0.35 release, it appears that all the necessary methods are implemented in corepc-{node|client}. I went ahead and updated the bdk-testenv and bdk-electrum/esplora crates.

It requires a more significant refactor and changes for the bdk_bitcoind_rpc, as the Emitter relies on the bitcoincore-rpc ' RpcApi' trait. I can cover it all in a single PR, but would like to know what you guys think as well.

cc @ValuedMammal @LagginTimes

ValuedMammal · 2025-08-12T14:49:16Z

Replaying a comment from discord

I also noticed that updating electrsd means potentially changing the Emitter to use corepc Client because of how it relates to testenv, etc. We have to make sure switching clients doesn't negatively impact behavior, performance and stuff

ValuedMammal · 2025-11-22T04:39:01Z

We may be able to unblock this by having a way to create a new RPC client using the node credentials of a TestEnv instance but independent of the actual test client that is used by electrsd. oleonardolima#3

oleonardolima · 2025-11-22T04:44:31Z

We may be able to unblock this by having a way to create a new RPC client using the node credentials of a TestEnv instance but independent of the actual test client that is used by electrsd. oleonardolima#3

Cool, I'll take a look at your PR this morning.

oleonardolima · 2025-11-24T18:02:53Z

We may be able to unblock this by having a way to create a new RPC client using the node credentials of a TestEnv instance but independent of the actual test client that is used by electrsd. oleonardolima#3

Alright, but if I got it right, the idea would to still rely on bitcoincore_rpc API for bdk_bitcoind_rpc tests (which I think makes sense), right ? And when we land bdk_bitcoind_client that wouldn't an issue anymore, right

oleonardolima · 2025-11-24T18:14:47Z

re-posting from oleonardolima#3 (comment)

Thanks for the suggestion, I'll cherry-pick this one and update the remaining tests.

oleonardolima · 2025-11-24T23:01:52Z

Also, it looks like the latest one is v0.36.1, I'll give it a try on that one too.

ValuedMammal · 2025-11-25T01:00:02Z

Alright, but if I got it right, the idea would to still rely on bitcoincore_rpc API for bdk_bitcoind_rpc tests (which I think makes sense), right ? And when we land bdk_bitcoind_client that wouldn't an issue anymore, right

The approach I had in mind is to bump electrsd to the latest version in bdk_testenv which might entail updating some methods in order to benefit from all new corepc types. In bdk_bitcoind_rpc we can start using the TestEnv client for tests, and this ClientExt trait or whatever we're calling it can be used to create a client just for the Emitter with no other code changes needed. When bdk_bitcoind_client is available we'll update the Emitter to use that and remove bitcoincore_rpc. Don't know if I've fully answered the question.

oleonardolima · 2025-11-29T21:00:52Z

AFAICT the only blocker now is: rust-bitcoin/corepc#425

- add `ClientExt` trait to it's own common module. - update the `bdk_bitcoind_rpc` lib.rs tests to use `ClientExt`. - update the `bdk_bitcoind_rpc` test_emitter.rs tests to use `ClientExt`. - update the `bdk_bitcoind_rpc` test_filter_iter.rs tests to use `ClientExt`.

- add new methods `list_unspent` and `get_raw_transaction_verbose` to `TestEnv`, it's need as they require specific arguments in the call, that are not available in corepc API.

oleonardolima · 2026-01-08T00:18:56Z

AFAICT the only blocker now is: rust-bitcoin/corepc#425

It's not a block anymore, by using the latest electrsd, the corepc-types are already fixed as it was suggested in the issue.

luisschwab · 2026-01-18T19:59:19Z

crates/bitcoind_rpc/src/lib.rs

+        let (chain, _) = LocalChain::from_genesis(env.genesis_hash()?);
        let chain_tip = chain.tip();
+
+        // TODO: (@oleonardolima) We should use the `ClientExt` trait instead.


Is this currently possible or do we need the new bdk_bitcoind_rpc client ready?

It's already possible, lingering TODO.

luisschwab · 2026-01-18T20:05:05Z

crates/chain/tests/test_indexed_tx_graph.rs

            env.mine_blocks(1, Some(sender_addr.clone()))?;
            env.mine_blocks(101, None)?;

+            // TODO: (@oleonardolima) remove unwraps


Lingering TODO here

Already solved those, forgot to remove the comment.

luisschwab · 2026-01-18T20:11:53Z

crates/chain/tests/test_indexed_tx_graph.rs

    impl ScenarioEnv {
        fn new() -> anyhow::Result<Self> {
            let env = TestEnv::new()?;
            let client = env.rpc_client();


Thought: why not drop TestEnv::rpc_client altogether and rely only on ClientExt::get_rpc_client(&env)?

It's the standard-way to use testenv's rpc client, the ClientExt is just a workaround to upgrade the bdk_testenv in bdk_bitcoind_rpc while we don't have the new client that relies on the same corepc types.

luisschwab · 2026-01-18T20:13:00Z

crates/chain/tests/test_indexed_tx_graph.rs

+            // let unconfirmed_txs = mempool_txids
+            //     .iter()
+            //     // .map(|txid| -> Result<_, _> { client.get_raw_transaction(*txid)?.into_model()
+            // })?     .map(
+            //         |txid| -> Result<
+            //             GetRawTransaction,
+            //             bdk_testenv::corepc_client::client_sync::Error,
+            //         > { client.get_raw_transaction(*txid) },
+            //     )
+            //     .collect::<Vec<Result<_, _>>>()
+            //     .map(|get_raw_tx| get_raw_tx.into_model())
+            //     .map(|tx| (tx.0, 0))
+            //     .collect::<Vec<(Transaction, u64)>>();


Needs resolving

It's solved, forgot to remove the comment.

luisschwab · 2026-01-18T20:21:50Z

crates/testenv/Cargo.toml

@@ -1,3 +1,3 @@
 [package]
 name = "bdk_testenv"
 version = "0.13.1"


Need to bump bdk_testenv's version as well

It's only bumped in the release PRs.

luisschwab · 2026-01-18T20:30:20Z

Tests are failing locally for me:

cargo test -p bdk_chain --all-features
   Compiling bdk_testenv v0.13.1 (/Users/luisschwab/git/bdk/crates/testenv)
error[E0432]: unresolved import `bdk_chain::bitcoin::secp256k1::rand`
   --> crates/testenv/src/lib.rs:8:20
    |
8   | ...   secp256k1::rand::random, transaction, Address, Amount, Block, BlockHas...
    |                  ^^^^ could not find `rand` in `secp256k1`
    |
note: found an item that was configured out
   --> /Users/luisschwab/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/secp256k1-0.29.1/src/lib.rs:186:9
    |
186 | pub use rand;
    |         ^^^^
note: the item is gated behind the `rand` feature
   --> /Users/luisschwab/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/secp256k1-0.29.1/src/lib.rs:185:7
    |
185 | #[cfg(feature = "rand")]
    |       ^^^^^^^^^^^^^^^^

For more information about this error, try `rustc --explain E0432`.
error: could not compile `bdk_testenv` (lib) due to 1 previous error
error: Recipe `_test-chain` failed on line 41 with exit code 101
error: Recipe `test` failed on line 30 with exit code 101

oleonardolima · 2026-01-19T20:20:50Z

Tests are failing locally for me:

cargo test -p bdk_chain --all-features
   Compiling bdk_testenv v0.13.1 (/Users/luisschwab/git/bdk/crates/testenv)
error[E0432]: unresolved import `bdk_chain::bitcoin::secp256k1::rand`
   --> crates/testenv/src/lib.rs:8:20
    |
8   | ...   secp256k1::rand::random, transaction, Address, Amount, Block, BlockHas...
    |                  ^^^^ could not find `rand` in `secp256k1`
    |
note: found an item that was configured out
   --> /Users/luisschwab/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/secp256k1-0.29.1/src/lib.rs:186:9
    |
186 | pub use rand;
    |         ^^^^
note: the item is gated behind the `rand` feature
   --> /Users/luisschwab/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/secp256k1-0.29.1/src/lib.rs:185:7
    |
185 | #[cfg(feature = "rand")]
    |       ^^^^^^^^^^^^^^^^

For more information about this error, try `rustc --explain E0432`.
error: could not compile `bdk_testenv` (lib) due to 1 previous error
error: Recipe `_test-chain` failed on line 41 with exit code 101
error: Recipe `test` failed on line 30 with exit code 101

Indeed, needs debugging. Still unsure why it's now failing.

luisschwab · 2026-01-19T20:39:47Z

I think you need to import bitcoin with the rand feature so it re-exports secp256k1 with it: https://docs.rs/crate/bitcoin/latest/features#rand

LagginTimes assigned oleonardolima Feb 7, 2025

oleonardolima force-pushed the deps/bump-electrsd-version branch from af3988d to b4d655a Compare February 9, 2025 02:57

ValuedMammal mentioned this pull request Feb 11, 2025

Update Dependencies for Compatibility and Security (Fixes #1797) #1804

Open

8 tasks

notmandatory mentioned this pull request Mar 5, 2025

Update bdk_wallet out of date dependencies bitcoindevkit/bdk_wallet#32

Open

6 tasks

oleonardolima force-pushed the deps/bump-electrsd-version branch 4 times, most recently from ef27736 to f52f04d Compare March 22, 2025 18:46

notmandatory added this to BDK Chain Apr 23, 2025

notmandatory added the dependencies Pull requests that update a dependency file label Apr 23, 2025

notmandatory removed this from BDK Wallet Apr 23, 2025

notmandatory moved this to In Progress in BDK Chain Apr 23, 2025

notmandatory mentioned this pull request Apr 26, 2025

Update bdk out of date dependencies #1949

Open

8 tasks

oleonardolima force-pushed the deps/bump-electrsd-version branch from f52f04d to e8fc019 Compare August 5, 2025 02:23

oleonardolima force-pushed the deps/bump-electrsd-version branch 4 times, most recently from 2ab640d to 366c9d9 Compare August 8, 2025 20:11

oleonardolima mentioned this pull request Sep 29, 2025

Replace rust-bitcoincore-rpc #2049

Open

oleonardolima force-pushed the deps/bump-electrsd-version branch from 366c9d9 to a2784f5 Compare November 24, 2025 01:37

oleonardolima force-pushed the deps/bump-electrsd-version branch 2 times, most recently from 33be1c7 to a83a8fe Compare November 29, 2025 20:24

oleonardolima mentioned this pull request Nov 29, 2025

The client_sync from v18 onwards still uses the old client_v17__list_unspent macro rust-bitcoin/corepc#425

Closed

oleonardolima force-pushed the deps/bump-electrsd-version branch from a83a8fe to 62d9c07 Compare January 7, 2026 21:21

oleonardolima and others added 4 commits January 7, 2026 20:59

deps(bdk_testenv): bump electrsd to 0.36.1

6eb8563

fix(tests): on bdk_chain

3cb1ff1

fix(tests): on bdk_esplora, bdk_electrum

10baef9

- add new methods `list_unspent` and `get_raw_transaction_verbose` to `TestEnv`, it's need as they require specific arguments in the call, that are not available in corepc API.

oleonardolima force-pushed the deps/bump-electrsd-version branch from fd8926d to 10baef9 Compare January 8, 2026 00:00

oleonardolima changed the title ~~deps(bdk_testenv): bump electrsd to 0.31.0~~ deps(bdk_testenv): bump electrsd to 0.36.1 Jan 8, 2026

oleonardolima requested review from ValuedMammal, evanlinjin, luisschwab and notmandatory January 8, 2026 00:16

oleonardolima moved this from In Progress to Needs Review in BDK Chain Jan 8, 2026

oleonardolima marked this pull request as ready for review January 8, 2026 00:17

luisschwab reviewed Jan 18, 2026

View reviewed changes

deps(bdk_testenv): bump electrsd to 0.36.1 #1826

Are you sure you want to change the base?

deps(bdk_testenv): bump electrsd to 0.36.1 #1826

Uh oh!

Conversation

oleonardolima commented Feb 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

New Features:

Uh oh!

oleonardolima commented Feb 7, 2025

Uh oh!

ValuedMammal commented Jul 21, 2025

Uh oh!

oleonardolima commented Jul 22, 2025

Uh oh!

ValuedMammal commented Jul 23, 2025

Uh oh!

oleonardolima commented Jul 24, 2025

Uh oh!

oleonardolima commented Aug 5, 2025

Uh oh!

oleonardolima commented Aug 8, 2025

Uh oh!

ValuedMammal commented Aug 12, 2025

Uh oh!

ValuedMammal commented Nov 22, 2025

Uh oh!

oleonardolima commented Nov 22, 2025

Uh oh!

oleonardolima commented Nov 24, 2025

Uh oh!

oleonardolima commented Nov 24, 2025

Uh oh!

oleonardolima commented Nov 24, 2025

Uh oh!

ValuedMammal commented Nov 25, 2025

Uh oh!

oleonardolima commented Nov 29, 2025

Uh oh!

oleonardolima commented Jan 8, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

luisschwab commented Jan 18, 2026

Uh oh!

oleonardolima commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

luisschwab commented Jan 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

deps(bdk_testenv): bump `electrsd` to `0.36.1` #1826

deps(bdk_testenv): bump `electrsd` to `0.36.1` #1826

oleonardolima commented Feb 6, 2025 •

edited

Loading

oleonardolima commented Jan 19, 2026 •

edited

Loading

luisschwab commented Jan 19, 2026 •

edited

Loading