Add is_empty methods to TxUpdate and {}_Response types#1961
Merged
evanlinjin merged 1 commit intobitcoindevkit:masterfrom May 23, 2025
Merged
Add is_empty methods to TxUpdate and {}_Response types#1961evanlinjin merged 1 commit intobitcoindevkit:masterfrom
is_empty methods to TxUpdate and {}_Response types#1961evanlinjin merged 1 commit intobitcoindevkit:masterfrom
Conversation
evanlinjin
force-pushed
the
feature/tx_update_is_empty
branch
from
0cf6f5b to
6785145
Compare
evanlinjin
force-pushed
the
feature/tx_update_is_empty
branch
from
6785145 to
83e8a70
Compare
LagginTimes
reviewed
May 19, 2025
Contributor
LagginTimes
left a comment
LagginTimes
left a comment
There was a problem hiding this comment.
Nit in doc comment. Otherwise, LGTM!
LagginTimes
force-pushed
the
feature/tx_update_is_empty
branch
from
83e8a70 to
e9263f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
is_emptymethods are helpful in various contexts so I added them.Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features: