Skip to content

Comments

fix(chain): persist first_seen#1966

Merged
evanlinjin merged 1 commit intobitcoindevkit:masterfrom
LagginTimes:persist_first_seen
May 23, 2025
Merged

fix(chain): persist first_seen#1966
evanlinjin merged 1 commit intobitcoindevkit:masterfrom
LagginTimes:persist_first_seen

Conversation

@LagginTimes
Copy link
Contributor

Fixes #1965.

Description

Adds missing persistence for first_seen, which was not included in #1950.

Changelog notice

  • Adds first_seen column to the bdk_txs table via schema v3 migration.
  • Updates from_sqlite() and persist_to_sqlite() to handle first_seen.
  • Updates the v0-to-v3 migration test to verify compatibility with older schemas.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo +nightly fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@LagginTimes LagginTimes self-assigned this May 23, 2025
Copy link
Member

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK b27a019

@evanlinjin evanlinjin merged commit cb66f00 into bitcoindevkit:master May 23, 2025
19 checks passed
@notmandatory notmandatory added the api A breaking API change label May 23, 2025
@notmandatory notmandatory moved this to Needs Review in BDK Chain May 23, 2025
@notmandatory notmandatory moved this to Needs Review in BDK Wallet May 23, 2025
@notmandatory notmandatory added this to the Wallet 2.0.0 milestone May 23, 2025
@notmandatory notmandatory moved this from Needs Review to Done in BDK Chain May 23, 2025
@notmandatory notmandatory moved this from Needs Review to Todo in BDK Wallet May 23, 2025
@ValuedMammal ValuedMammal mentioned this pull request May 26, 2025
39 tasks
@LagginTimes LagginTimes mentioned this pull request Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api A breaking API change

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Persist tx_graph::ChangeSet::first_seen

3 participants