feat(chain)!: make CheckPoint data field optional
#2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evanlinjin
requested changes
Sep 10, 2025
evanlinjin
reviewed
Sep 10, 2025
6 tasks
LagginTimes
force-pushed
the
optional_data
branch
2 times, most recently
from
cf98f58 to
eddadd4
Compare
|
Some recommended test scenarios:
With the above tests:
|
LagginTimes
force-pushed
the
optional_data
branch
from
e805152 to
86968bb
Compare
3 tasks
LagginTimes
force-pushed
the
optional_data
branch
2 times, most recently
from
942d438 to
e1166b6
Compare
* Base tip must always have data. * Update should be able to introduce data to a placeholder checkpoint in the original chain. * Remove unnecessary logic.
LagginTimes
force-pushed
the
optional_data
branch
from
e1166b6 to
46bd424
Compare
There was a problem hiding this comment.
cACK c24dd6a
It looking good code-wise, though we probably need further discussion on what's the best approach, as discussed by Evan and VM in discord.
6 tasks
evanlinjin
requested changes
Sep 25, 2025
Add comprehensive tests for CheckPoint::push error cases: - Push fails when height is not greater than current - Push fails when prev_blockhash conflicts with self - Push succeeds when prev_blockhash matches - Push creates placeholder for non-contiguous heights Include tests for CheckPoint::insert conflict handling: - Insert with conflicting prev_blockhash - Insert purges conflicting tail - Insert between conflicting checkpoints 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
LagginTimes
force-pushed
the
optional_data
branch
from
ba55b7e to
a216494
Compare
evanlinjin
reviewed
Sep 29, 2025
| /// | ||
| /// This panics if called with a genesis block that differs from that of `self`. | ||
| #[must_use] | ||
| pub fn insert(self, height: u32, data: D) -> Self { |
There was a problem hiding this comment.
Insert now looks really complicated. Do you have any ideas to simplify it?
LagginTimes
force-pushed
the
optional_data
branch
from
a216494 to
ae040c2
Compare
LagginTimes
force-pushed
the
optional_data
branch
from
ae040c2 to
460bc46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2021.
Description
This PR makes the
CheckPoint::datafield optional. Gaps inferred fromprev_blockhashare represented as placeholder checkpoints wheredataisNone. Subsequentinsert()s will providedatafor the placeholders when a matching block arrives.See: #2017 (comment)
Notes to the reviewers
WIP
Changelog notice
Checklists
All Submissions:
New Features:
Bugfixes: