chain: replace ScriptBuf with &Script in SPK index methods

[yukibtc]

Description

Replace ScriptBuf with &Script in SpkTxOutIndex::index_of_spk and KeychainTxOutIndex::index_of_spk methods, to avoid the need of cloning the ScriptBuf for a SPK index lookup.

Changelog notice

Breaking changes:

• Change SpkTxOutIndex::index_of_spk and KeychainTxOutIndex::index_of_spk args from ScriptBuf to &Script.

Checklists

All Submissions:

• I followed the contribution guidelines

New Features:

• I've added tests for the new feature
• I've added docs for the new feature

Bugfixes:

• This pull request breaks the existing API
• I've added tests to reproduce the issue which are now passing
• I'm linking the issue being fixed by this PR

[ValuedMammal]

Thank you @yukibtc.

[evanlinjin]

Concept ACK.

For ergonomics, what do you think about having spk: impl AsRef<Script>? This way the caller can use ScriptBuf, &Script, Box<Script>, etc.

For methods that take ownership of the script, maybe we should change to spk: impl Into<ScriptBuf> - however, this will increase the scope of the PR - should be okay since we are relaxing bounds. Let me know what you think.

[yukibtc]

For ergonomics, what do you think about having spk: impl AsRef<Script>? This way the caller can use ScriptBuf, &Script, Box<Script>, etc.

Agree, I've updated to take AsRef<Script> instead.

For methods that take ownership of the script, maybe we should change to spk: impl Into - however, this will increase the scope of the PR - should be okay since we are relaxing bounds. Let me know what you think.

Yeah, maybe is better to do this in a dedicated PR

[yukibtc]

Seems that CI failed for a electrsd timeout

[aagbotemi]

Code tested and result look okay.

[oleonardolima]

cACK c095145

[evanlinjin]

ACK c095145