chore(msrv): bump MSRV to 1.85.0
#2055
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oleonardolima
force-pushed
the
chore/bump-msrv-to-1.85.0
branch
from
b04bbed to
b6e75cb
Compare
oleonardolima
added
chore
evanlinjin
approved these changes
Oct 2, 2025
There was a problem hiding this comment.
ACK b6e75cb
Ran cargo test --all-features with:
❯ cargo --version
cargo 1.85.0 (d73d2caf9 2024-12-31)
2 tasks
4 tasks
oleonardolima
force-pushed
the
chore/bump-msrv-to-1.85.0
branch
2 times, most recently
from
8bb3255 to
93c2172
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
oleonardolima
force-pushed
the
chore/bump-msrv-to-1.85.0
branch
2 times, most recently
from
3e626f3 to
adc99e7
Compare
|
I've added new commits bumping the criterion version and updating the toolchain action to match the one used in bdk_wallet. Still need to debug the CI failure now. |
Scratch that, I didn't notice it was only in the test module. |
oleonardolima
force-pushed
the
chore/bump-msrv-to-1.85.0
branch
from
adc99e7 to
b4f3c30
Compare
- update all references to previous 1.63.0 MSRV. - update the rust-version to 1.85.0. - update the CI to not exclude bdk_electrum anymore. - update the ci/pin-msrv.sh to 1.85.0.
- use `is_non_or` instead of `map_or` - update lifetime on `find_direct_anchor`
oleonardolima
force-pushed
the
chore/bump-msrv-to-1.85.0
branch
from
b4f3c30 to
0f5ac52
Compare
|
cACK, will do a deeper review when I get a chance but don't wait for me if you think it's ready to go. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2009
Description
It bumps the project MSRV to 1.85.0, as the latest Debian trixie release establishes that as stable, see: https://tracker.debian.org/pkg/rustc.
This PR does:
bdk_electrumanymore.Notes to the reviewers
Should we update something in the GitHub repository configuration to get rid of old mandatory CI jobs ?
Changelog notice
Checklists
All Submissions: