clippy: fix uninlined format args #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lint should have stayed in "pedantic". The lint itself isn't helpful because it doesn't always improve readability, and inlining won't work if the argument is an expression or field access.
Pull Request Test Coverage Report for Build 16654683048Details
💛 - Coveralls |
| @@ -7,6 +7,7 @@ | |||
| )] | |||
| #![no_std] | |||
| #![warn(missing_docs)] | |||
| #![allow(clippy::uninlined_format_args)] | |||
There was a problem hiding this comment.
I wouldn't mind leaving this lint enabled even if it's a bit pedantic. But no strong feelings about it either way so OK to allow for now.
notmandatory
approved these changes
Jul 31, 2025
There was a problem hiding this comment.
ACK d75126e
You'll need to update the master branch rules settings to version 1.88.0 before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #281 by taking clippy's suggestion to inline the arguments to a
format!string where applicable.Also update
rust-versionto 1.88.0, closing #280.Notes to the reviewers
I've gone ahead and fixed the clippy warnings, although some have argued that the lint is quite pedantic and not entirely helpful when it comes to style and readability. Therefore I also allowed the lint to prevent clippy from warning about it in the future d75126e. That change can be reverted if/when rust lang moves
uninlined_format_argsback to the pedantic, i.e. not default group of lints rust-lang/rust-clippy#15287.Checklists
All Submissions:
This pull request breaks the existing API