-
Notifications
You must be signed in to change notification settings - Fork 53
feat: public key generation from descriptors #355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #355 +/- ##
==========================================
+ Coverage 85.24% 85.26% +0.01%
==========================================
Files 23 23
Lines 8230 8273 +43
==========================================
+ Hits 7016 7054 +38
- Misses 1214 1219 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
AdamuAbba
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK 7ac497f
| use crate::test_utils::insert_tx; | ||
|
|
||
| #[test] | ||
| fn test_generate_publick_keys() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor typo in function name k in public
| fn test_generate_publick_keys() { | |
| fn test_generate_public_keys() { |

Description
This PR as a new function to the wallet API
public_key_at_index(keychain, index)which returns the public key found at the specified index. It closes #209Notes to the reviewers
I explicitly matched all arms branches of the
Descriptor<DefiniteDescriptorKey>so that if a new type is added in the future it signals there is a need to update this function too.Changelog notice
public_key_at_index(keychain, index)which returns the public key found at the specified index.Checklists
All Submissions:
just pbefore pushingNew Features: