Skip to content

[backport] Add get_pre_1_wallet_keychains migration helper #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
notmandatory wants to merge 1 commit into
base: release/2.x
Choose a base branch
from
Draft

[backport] Add get_pre_1_wallet_keychains migration helper #365

notmandatory wants to merge 1 commit into from
+139 −0

Conversation

@notmandatory
Copy link
Member

@notmandatory notmandatory commented Jan 12, 2026 •
edited
Loading

Description

Add wallet/migration module and get_pre_1_wallet_keychains() to help migrate users from a pre-1.0 bdk sqlite database. This new function returns the last revealed index and checksum value for each keychain it finds.

Notes to the reviewers

This is a backport to the release/2.x branch of #364.

Changelog notice

  • Add get_pre_1_wallet_keychains to assist migration from pre-1.0 bdk wallets. (back ported from 3.x)

Checklists

All Submissions:

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

@notmandatory notmandatory force-pushed the backport/sqlite_pre1_migration_helper branch from b1b9763 to 7624182 Compare January 12, 2026 23:29
@notmandatory notmandatory force-pushed the backport/sqlite_pre1_migration_helper branch from 7624182 to f19c6fb Compare January 12, 2026 23:36
@notmandatory notmandatory changed the title Backport/sqlite pre1 migration helper [backport] Add get_pre_1_wallet_keychains migration helper Jan 12, 2026
@notmandatory notmandatory changed the base branch from master to release/2.x January 12, 2026 23:38
@notmandatory notmandatory marked this pull request as ready for review January 12, 2026 23:39
@notmandatory notmandatory self-assigned this Jan 12, 2026
@notmandatory notmandatory added the new feature New feature or request label Jan 12, 2026
@notmandatory notmandatory moved this to Needs Review in BDK Wallet Jan 12, 2026
@notmandatory notmandatory added this to the Wallet 2.4.0 milestone Jan 12, 2026
@notmandatory notmandatory marked this pull request as draft January 12, 2026 23:41
@notmandatory
Copy link
Member Author

notmandatory commented Jan 12, 2026

I'll mark this as ready to review after #364 is merged to make sure they match.

@notmandatory notmandatory mentioned this pull request Jan 12, 2026
Closed
6 tasks
thunderbiscuit
thunderbiscuit approved these changes Jan 13, 2026
View reviewed changes
Copy link
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK f19c6fb.

@thunderbiscuit thunderbiscuit mentioned this pull request Jan 14, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thunderbiscuit thunderbiscuit thunderbiscuit approved these changes

@ValuedMammal ValuedMammal Awaiting requested review from ValuedMammal ValuedMammal is a code owner

Assignees

@notmandatory notmandatory

Labels

new feature New feature or request

Projects

BDK Wallet
Status: Needs Review

Milestone

Wallet 2.4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@notmandatory @thunderbiscuit