feat!: add wallet birthday #368
Draft
+68
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luisschwab
requested review from
ValuedMammal,
oleonardolima and
thunderbiscuit
luisschwab
force-pushed
the
feat/wallet-birthday
branch
from
527a8d4 to
77e2d88
Compare
luisschwab
force-pushed
the
feat/wallet-birthday
branch
from
77e2d88 to
8ea292f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, needs bitcoindevkit/bdk#2097
This PR adds a birthday to the wallet, as a
BlockId. Block-by-Block and CBF scanning can use this as a hint to only scan from the birthday onwards, saving time and bandwidth on full-scans where the birthday is previously known.Client code should be updated to automatically set the birthday when performing a full-scan.
TODO
bitcoind_rpcexample that uses the birthday as thestart_height