Skip to content

Conversation

@luisschwab
Copy link
Member

@luisschwab luisschwab commented Jan 18, 2026

Description

Closes #95.

This PR adds reasoning to the ignored policy extraction tests (see bdk#225 for context), and adds missing assertions on a couple of timelock merging tests that were missing.

Checklists

All Submissions:

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

- Justify ignored policy extraction tests
- Add missing timelock merging test assertions
@codecov
Copy link

codecov bot commented Jan 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.30%. Comparing base (8f8a8e9) to head (3cc5b98).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #369      +/-   ##
==========================================
+ Coverage   85.33%   86.30%   +0.96%     
==========================================
  Files          24       24              
  Lines        8335     8346      +11     
==========================================
+ Hits         7113     7203      +90     
+ Misses       1222     1143      -79     
Flag Coverage Δ
rust 86.30% <100.00%> (+0.96%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@luisschwab luisschwab self-assigned this Jan 18, 2026
@luisschwab luisschwab moved this to Needs Review in BDK Wallet Jan 18, 2026
@luisschwab luisschwab added the tests New or improved tests label Jan 18, 2026
@luisschwab luisschwab added this to the Wallet 2.4.0 milestone Jan 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests New or improved tests

Projects

Status: Needs Review

Development

Successfully merging this pull request may close these issues.

ignore reasons

1 participant