Refactor: Move Wallet errors into their dedicated file
#378
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
src/wallet/mod.rsis currently a very big file (3200 lines exactly), and over the course of my work on #318 I noticed a few small refactors that could help keep things tidy (ok it's a drop in the bucket but still a win!) and reduce the line count a bit.Notes to the reviewers
We had 3 wallet-related errors that were defined in the mod.rs file, but we also have a dedicated
error.rsfile which states://! Errors that can be thrown by the `Wallet`The errors belong there in my opinion, and this is a small refactor moving them over.
Changelog notice
No changelog required.
Checklists
All Submissions:
just pbefore pushingNew Features:
Bugfixes: