fix(doc): reword CreateWithPersistError::Descriptor doc comment
#381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shytypes <[email protected]>
Collaborator
|
Thank you @AdamuAbba |
ValuedMammal
added a commit
that referenced
this pull request
Feb 9, 2026
… comment 5ba59ad fix(doc): reword `CreateWithPersistError::Descriptor` doc comment (shytypes) Pull request description: <!-- You can erase any parts of this template not applicable to your Pull Request. --> closes #358 ### Description <!-- Describe the purpose of this PR, what's being adding and/or fixed --> Rewords the doc comment on `CreateWithPersistError::Descriptor` (loaded changeset -> provided descriptor(s)) ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `just p` before pushing ACKs for top commit: luisschwab: ACK 5ba59ad ValuedMammal: ACK 5ba59ad Tree-SHA512: 55b9d86b5eca8a6c254f6dc74fe7c19d28cfff914248b13c51d19427d520db8247c54d2af54433008bae6b767dc883d092b9ddbbb4eb9f96d7aac56871b8d9bd
Collaborator
|
Somehow github failed to recognize the merge. The commit 5ba59ad has landed on master AFAICT, but let me know if something doesn't look it right. |
Member
|
I guess GitHub wen't down just as you merged this and things got messed up in their DB. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #358
Description
Rewords the doc comment on
CreateWithPersistError::Descriptor(loaded changeset -> provided descriptor(s))
Checklists
All Submissions:
just pbefore pushing