Upgrade dependencies #190
Merged
Upgrade dependencies #190
+179
−133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for awesome-golick-685c88 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Wow thanks for the super quick fix! ACK a5317cc. I see why I couldn't find it; I'm not part of the spiralxyz org. All is good now! |
thunderbiscuit
approved these changes
Aug 9, 2024
|
Ok actually it only worked locally because I had added the method to my local theme. When I remove the function it still doesn't build, even though my package-lock shows "@spiralbtc/vuepress-devkit-theme": "^0.19.0", |
|
Did you run |
|
I had not! Thanks. But actually even after doing that I get the same error. Both my package.json and package-lock.json use the It also appears that it's breaking for Netlify (#189). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the build issues in #189.
@thunderbiscuit Can you check if this resolves the build error for you and if so merge this and then rebase your blog PR on top of the fix?
@ConorOkus updated the spiral theme and the latest version already includes the missing function. For reference: The theme is maintained here: https://github.com/spiralxyz/vuepress-devkit-theme