Skip to content

Adoption: proton wallet #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2024
Merged

Adoption: proton wallet #193

merged 1 commit into from
Sep 11, 2024

Conversation

reez
Copy link
Collaborator

@reez reez commented Sep 4, 2024

Pending OK from Proton Wallet

@netlify Netlify
Copy link

netlify bot commented Sep 4, 2024 •
edited
Loading

✅ Deploy Preview for awesome-golick-685c88 ready!

Name Link
🔨 Latest commit 765a178
🔍 Latest deploy log https://app.netlify.com/sites/awesome-golick-685c88/deploys/66e1b84fb187ee00083f05c5
😎 Deploy Preview https://deploy-preview-193--awesome-golick-685c88.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@notmandatory
Copy link
Member

Please also add them to the "Web" section. :-)

@reez
Copy link
Collaborator Author

reez commented Sep 4, 2024

Please also add them to the "Web" section. :-)

will do right now, thanks!!

@notmandatory
Copy link
Member

I got the OK from my contact at Proton but he'd like to use for the blurb:

A self-custodial Bitcoin wallet from the makers of Proton Mail.

Also I'd like to see if we can find a .png for the logo with a transparent background so the logo doesn't have the white box when in dark mode. I'll ask one of their designers if they can help get one for us.

@reez
Copy link
Collaborator Author

reez commented Sep 7, 2024

I got the OK from my contact at Proton but he'd like to use for the blurb:

A self-custodial Bitcoin wallet from the makers of Proton Mail.

great! updated the blurb.

@notmandatory
Copy link
Member

Here are some official logos from Proton, I think the transparent PNG will look best but give it a try.

Proton-Wallet-logos.zip

@reez reez force-pushed the proton branch 3 times, most recently from e50f135 to 2508f29 Compare September 11, 2024 15:26
@reez reez changed the title (draft) adoption: proton wallet adoption: proton wallet Sep 11, 2024
@reez reez marked this pull request as ready for review September 11, 2024 15:34
@reez reez requested a review from notmandatory September 11, 2024 15:34
@notmandatory notmandatory changed the title adoption: proton wallet Adoption: proton wallet Sep 11, 2024
notmandatory
notmandatory approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@notmandatory notmandatory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 765a178

I tested in light and dark mode and both look good!

@reez reez merged commit 4578671 into bitcoindevkit:master Sep 11, 2024
5 checks passed
@reez reez deleted the proton branch September 11, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@notmandatory notmandatory notmandatory approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reez @notmandatory