Skip to content

Conversation

notmandatory
Copy link
Member

@notmandatory notmandatory commented Nov 23, 2024

@notmandatory notmandatory self-assigned this Nov 23, 2024
Copy link

netlify bot commented Nov 23, 2024

Deploy Preview for awesome-golick-685c88 ready!

Name Link
🔨 Latest commit 494000b
🔍 Latest deploy log https://app.netlify.com/sites/awesome-golick-685c88/deploys/674e7424f8009600070bbd2b
😎 Deploy Preview https://deploy-preview-206--awesome-golick-685c88.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@notmandatory notmandatory force-pushed the blog/2024_audit branch 2 times, most recently from 7d8a45b to ddf96aa Compare November 24, 2024 01:07
@notmandatory
Copy link
Member Author

I also added a copy of the original audit github gist files. If some day the github version goes away we can link to our own static copy.

@thunderbiscuit
Copy link
Member

Awesome post!

Copy link
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

Copy link
Collaborator

@reez reez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 1229348

This looks awesome I think people will be really interested in this.

Even though they aren't blockers to an ACK from me, I did add a suggestion and nit, and then I also really like the suggestions @nymius added

@nymius
Copy link

nymius commented Dec 2, 2024

Should Fixes/Resolves bitcoindevkit/bdk#1720 marker be in the PR description?

@notmandatory notmandatory force-pushed the blog/2024_audit branch 2 times, most recently from 7063c4e to cdbe13a Compare December 3, 2024 02:58
@notmandatory notmandatory merged commit 83c6604 into bitcoindevkit:master Dec 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: BDK audit report
4 participants