feat: add id_from_pos support
#155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LagginTimes
force-pushed
the
id_from_pos
branch
from
87e1cca to
ff8e4ac
Compare
evanlinjin
requested changes
Nov 1, 2024
Member
evanlinjin
left a comment
evanlinjin
left a comment
There was a problem hiding this comment.
Looks good to me. I would just change naming to be a bit more "conventional". I.e. transaction_id should be txid.
LagginTimes
force-pushed
the
id_from_pos
branch
from
ff8e4ac to
76f7fc8
Compare
8 tasks
LagginTimes
force-pushed
the
id_from_pos
branch
from
76f7fc8 to
a871b08
Compare
7 tasks
radiant-smith-lk20
added a commit
to radiant-smith-lk20/rust-electrum-client
that referenced
this pull request
Dec 15, 2025
… support
a871b084ec04b86d8c326a44f817038c5afe1c8e feat: add `id_from_pos` support (Wei Chen)
Pull request description:
This PR introduces the `blockchain.transaction.id_from_pos` feature from Electrum. This functionality is essential for an ongoing implementation in `bdk_electrum`, which requires retrieving the coinbase transaction from a block at a specified `height`. Currently, there is no straightforward method to achieve this. By implementing the `id_from_pos` feature, we will effectively address this gap.
ACKs for top commit:
oleonardolima:
utACK a871b084ec04b86d8c326a44f817038c5afe1c8e
ValuedMammal:
ACK a871b084ec04b86d8c326a44f817038c5afe1c8e
evanlinjin:
ACK a871b084ec04b86d8c326a44f817038c5afe1c8e
Tree-SHA512: e8f1ab44473f67030b4f19e766fcee472b7cfc1dac6df8c9f0e08d966e0ed48289de03768771623b9fc7e7ef15dacdb7e3b26c04f9b0de7566d67cc7585a7fa6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
blockchain.transaction.id_from_posfeature from Electrum. This functionality is essential for an ongoing implementation inbdk_electrum, which requires retrieving the coinbase transaction from a block at a specifiedheight. Currently, there is no straightforward method to achieve this. By implementing theid_from_posfeature, we will effectively address this gap.