chore(api)!: remove BlockSummary and PrevOut, rename scripthash_txs to get_scripthash_txs
#157
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Leaving as draft until
v0.12.2is released.Closes #142.
Closes #146.
Closes #148.
This PR:
BlockSummaryand usesBlockInfoforget_blocks, asBlockSummaryfails to capture the full response,PrevOut, which is identical toVout,scripthash_txstoget_scripthash_txs, to maintain the method naming convention.Amountfor all value/fee fields and removedTx::fee(),u64in favor ofWeightonTxand removedTx::weight().I'll also close #150 on this PR if we reach consensus on whether
Amountshould be used for all amount fields.