This repository was archived by the owner on Jan 22, 2026. It is now read-only.
Refactor: Separate interface from HWI calls and add HWI binary support#105
Open
ben-kaufman wants to merge 9 commits intobitcoindevkit:masterfrom
Open
Refactor: Separate interface from HWI calls and add HWI binary support#105ben-kaufman wants to merge 9 commits intobitcoindevkit:masterfrom
ben-kaufman wants to merge 9 commits intobitcoindevkit:masterfrom
Conversation
ben-kaufman
force-pushed
the
separate-python
branch
3 times, most recently
from
e1a5bcc to
6a9c40c
Compare
ben-kaufman
force-pushed
the
separate-python
branch
from
6a9c40c to
4fa5ace
Compare
ben-kaufman
force-pushed
the
separate-python
branch
from
4fa5ace to
fa1ed3e
Compare
ben-kaufman
force-pushed
the
separate-python
branch
from
fa1ed3e to
78ddcf9
Compare
ben-kaufman
force-pushed
the
separate-python
branch
2 times, most recently
from
fe20da9 to
fccbed0
Compare
ben-kaufman
force-pushed
the
separate-python
branch
from
12b24ec to
fe0f111
Compare
Author
|
@notmandatory I've fixed the issue from the merge of the Signer. The PR should be ready for review. |
Member
|
@ben-kaufman sorry for the delay in reviewing this. I've been focused on the bdk 1.0 work. Will test this out as soon as I can. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Benefits
Fix #92 by allowing to use rust-hwi with a binary file that can be easily packaged inside a consumer directed desktop app.