Optimize OPS type from Record to Enum

[decentraldev1]

• Optimize OPS type from Record to Enum
• Standardize the definition and use of keys in OPS
• Dealing with previous issues and PRs
  PR：https://github.com/bitcoinjs/bitcoinjs-lib/pull/2028/files
  Issue: Better types for opcodes #1966

[decentraldev1]

Going a step further, maybe we can remove REVERSE_OPS directly.

Which a bit redundant

[junderw]

Please make fix for the logic change. Also add a test to show that hex pushdatas that look like numbers in REVERSE_OPS are properly done as PUSHDATA.

[junderw]

Thanks for the fix and tests.

Could you also add a test for fromASM similar to how this edge case test for toASM works?:

bitcoinjs-lib/test/script.spec.ts

Lines 44 to 57 in e0c3ede

	describe('toASM', () => {
	const OP_RETURN = bscript.OPS.OP_RETURN;
	it('encodes empty buffer as OP_0', () => {
	const chunks = [OP_RETURN, Buffer.from([])];
	assert.strictEqual(bscript.toASM(chunks), 'OP_RETURN OP_0');
	});
	for (let i = 1; i <= 16; i++) {
	it(`encodes one byte buffer [${i}] as OP_${i}`, () => {
	const chunks = [OP_RETURN, Buffer.from([i])];
	assert.strictEqual(bscript.toASM(chunks), 'OP_RETURN OP_' + i);
	});
	}
	});

See how this test is testing an edge case for toASM (making sure empty array is OP_FALSE)

Can you add an edge case test for fromASM testing that '82 83 84' becomes [1, 130, 1, 131, 1, 132]

[decentraldev1]

Thanks for the fix and tests.

Could you also add a test for fromASM similar to how this edge case test for toASM works?:

bitcoinjs-lib/test/script.spec.ts

Lines 44 to 57 in e0c3ede

	describe('toASM', () => {
	const OP_RETURN = bscript.OPS.OP_RETURN;
	it('encodes empty buffer as OP_0', () => {
	const chunks = [OP_RETURN, Buffer.from([])];
	assert.strictEqual(bscript.toASM(chunks), 'OP_RETURN OP_0');
	});
	for (let i = 1; i <= 16; i++) {
	it(`encodes one byte buffer [${i}] as OP_${i}`, () => {
	const chunks = [OP_RETURN, Buffer.from([i])];
	assert.strictEqual(bscript.toASM(chunks), 'OP_RETURN OP_' + i);
	});
	}
	});

See how this test is testing an edge case for toASM (making sure empty array is OP_FALSE)

Can you add an edge case test for fromASM testing that '82 83 84' becomes [1, 130, 1, 131, 1, 132]

of course