Skip to content

Fix transaction version field not properly serialized #2202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Fix transaction version field not properly serialized #2202

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dd3af41
Fix tx version serialization
adambor Jan 24, 2025
df4297c
fix other uint errors
junderw Mar 5, 2025
9626d69
Merge branch 'master' into ab/tx-version-serialization
junderw Mar 5, 2025
35bb39f
Fix uint32 test
junderw Mar 5, 2025
3b9b426
Fix transaction.cjs
junderw Mar 5, 2025
55d2e93
Fix transaction.js
junderw Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ts_src/transaction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -652,7 +652,7 @@ export class Transaction {

const bufferWriter = new BufferWriter(buffer, initialOffset || 0);

bufferWriter.writeInt32(this.version);
bufferWriter.writeUInt32(this.version);

const hasWitnesses = _ALLOW_WITNESS && this.hasWitnesses();

Expand Down