qt: Fix crash in block view during IBD #106
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a crash that occurs when the block view window is open during initial block download (IBD). The crash happens due to a memory alignment issue in Qt's string handling when updating the block height from a non-main thread. The issue occurs in `GuiBlockView::updateBestBlock` where string formatting is performed on the b-scheduler thread instead of the main GUI thread. This is unsafe as Qt's string handling and GUI operations must be performed on the main thread. The fix uses `QMetaObject::invokeMethod` with `Qt::QueuedConnection` to ensure the string formatting and GUI update happens on the main thread, preventing the memory alignment issue. This is a follow-up to commit d69357d and fixes issue bitcoin#105 Tested by: - Opening block view during IBD - Verifying block height updates work correctly - Confirming no crashes occur during IBD
Collaborator
|
I believe this is fixed already in the upcoming Knots 29, please confirm (branch |
|
Tested this on latest, it seems fixed. @rebroad please verify and close |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a crash that occurs when the block view window is open during initial block download (IBD). The crash happens due to a memory alignment issue in Qt's string handling when updating the block height from a non-main thread.
The issue occurs in
GuiBlockView::updateBestBlockwhere string formatting is performed on the b-scheduler thread instead of the main GUI thread. This is unsafe as Qt's string handling and GUI operations must be performed on the main thread.The fix uses
QMetaObject::invokeMethodwithQt::QueuedConnectionto ensure the string formatting and GUI update happens on the main thread, preventing the memory alignment issue.This is a follow-up to commit d69357d and fixes issue #105
Tested by: