-
Notifications
You must be signed in to change notification settings - Fork 135
feat(rpc): Export GUI Policy Options for Headless Deployments #154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 29.x-knots
Are you sure you want to change the base?
feat(rpc): Export GUI Policy Options for Headless Deployments #154
Conversation
luke-jr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a lot to review here, so this isn't complete comments yet.
|
Thank you for taking a look @luke-jr I greatly appreciate it. This is still a WIP and there's more I'd like to do here, but your comments are really helpful as I work through this to ensure it meets Knots' standards. |
|
One issue is going to be review. This is largely one giant commit, which makes it difficult. Can you break it up into smaller steps? You're also putting a lot in the RPC code. At the end of this, we should ideally have RPC and GUI using the same code for changing settings. So an internal interface for updatesettings called by both would be appropriate. There's a lot of existing parsing code that you can probably reuse too (eg, boolean string to boolean UniValue conversions...) |
|
@luke-jr for review purposes, would it be better to break this into several PRs, or would you rather have everything in one PR? |
|
Multiple PRs could make sense, but there's tradeoffs. As long as it's broken up into logical separate commits, that's probably good enough. |
a542761 to
8abfb47
Compare
a70f6c4 to
85d3d8e
Compare
Summary
Add RPC commands to export/import GUI policy settings for headless systems (Start9, Umbrel).
Relates to #130
Changes
dumpsettings: Export settings to JSON with optional detailed metadata (replaces separategetsettings)getsettingsschema: Generate JSON Forms schemasetsettings: Update individual settings (renamed fromsetsetting)updatesettings: Bulk atomic updatessubscribesettings: Change notificationsSecurity & UX improvements:
include_sensitiveparameter)GUI export/import buttons and ZMQ notifications included.
Test plan