Skip to content

split lcov and genhtml cmake opts for the Coverage profile #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 9 commits into
base: 29.x-knots
Choose a base branch
from
Draft

split lcov and genhtml cmake opts for the Coverage profile #224

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7aa60c6
split rcov and genhtml cmake opts for the Coverage profile
tevio Oct 16, 2025
39f21c9
remove unnessecary duplicated set commands
tevio Oct 17, 2025
c115fc1
document the option
tevio Oct 19, 2025
e2d638f
remove duplicated lines and inline genhtml seperate_arguments
tevio Oct 19, 2025
b71b968
remove ENV overrides, shorten opt name, only allow setting via cmake …
tevio Oct 19, 2025
2c2d23e
make HTML_OPTS an override to LCOV_OPTS, for genhtml
tevio Oct 21, 2025
e3e917f
adapt commentary and make notes more concise
tevio Oct 24, 2025
97a898f
Default genhtml opts to LCOV_OPTS; respect explicitly empty HTML_OPTS
tevio Oct 24, 2025
b581b44
simplify logic for genhtml opt passing options, remove unnecessary guard
tevio Nov 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion cmake/script/CoverageInclude.cmake.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,20 @@
# Distributed under the MIT software license, see the accompanying
# file COPYING or https://opensource.org/license/mit/.

if(NOT DEFINED LCOV_OPTS)
set(LCOV_OPTS "$ENV{LCOV_OPTS}")
endif()
if(NOT DEFINED GENHTML_OPTS)
set(GENHTML_OPTS "$ENV{GENHTML_OPTS}")
endif()
separate_arguments(LCOV_OPTS)
separate_arguments(GENHTML_OPTS)

set(LCOV_COMMAND ${LCOV_EXECUTABLE} --gcov-tool ${CMAKE_CURRENT_LIST_DIR}/cov_tool_wrapper.sh ${LCOV_OPTS})
set(GENHTML_COMMAND ${GENHTML_EXECUTABLE} --show-details ${GENHTML_OPTS})

list(APPEND LCOV_FILTER_COMMAND -p "CMakeFiles/")

if("@CMAKE_CXX_COMPILER_ID@" STREQUAL "Clang")
find_program(LLVM_COV_EXECUTABLE llvm-cov REQUIRED)
set(COV_TOOL "${LLVM_COV_EXECUTABLE} gcov")
Expand All @@ -24,7 +38,7 @@ separate_arguments(LCOV_OPTS)
set(LCOV_COMMAND ${LCOV_EXECUTABLE} --gcov-tool ${CMAKE_CURRENT_LIST_DIR}/cov_tool_wrapper.sh ${LCOV_OPTS})

find_program(GENHTML_EXECUTABLE genhtml REQUIRED)
set(GENHTML_COMMAND ${GENHTML_EXECUTABLE} --show-details ${LCOV_OPTS})
set(GENHTML_COMMAND ${GENHTML_EXECUTABLE} --show-details ${GENHTML_OPTS})

find_program(GREP_EXECUTABLE grep REQUIRED)
find_program(AWK_EXECUTABLE awk REQUIRED)
Expand Down