Open
Conversation
rrozek555
commented
Jan 20, 2021
rrozek555
commented
msmorawski
suggested changes
Jan 28, 2021
Contributor
msmorawski
left a comment
msmorawski
left a comment
There was a problem hiding this comment.
You should change base branch to develop, as far I'm aware
| networkWIF = 0xef; | ||
| } else { | ||
| networkWIF = 0x80; | ||
| } |
Contributor
There was a problem hiding this comment.
Wouldn't it be clearer to extract it to function?
| import * as ecurve from 'ecurve'; | ||
| import { GeneratedKey } from '../components/pages/keyGenerator/KeyGeneratorContent'; | ||
| const bigi = require('bigi'); | ||
| const wif = require('wif'); |
Contributor
There was a problem hiding this comment.
As far as I can see wif comes with types, so instead of
const wif = require('wif');
use import
| multiline: 'Multiline', | ||
| publicKeyQrCode: 'Public key QR code', | ||
| privateKey: 'Private key', | ||
| privateKeyWIF: 'Private key in WIF', |
Contributor
There was a problem hiding this comment.
Before merge, please add translations or at least placeholders. We don't want the users to see typical for JS "undefined"
| {words?.map((word, index) => (<Chip key={index} label={`${index + 1}. ${word}`} />))} | ||
| </div> | ||
| <Label label={en.content.privateKeyWIF} /> | ||
| <Label label={privateKeyWIF} /> |
Contributor
There was a problem hiding this comment.
Wouldn't it better to place it in a multiline field? It should be easier for users to copy it then, I believe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.