Conversation
ToveRumar
force-pushed
the
toverumar/wifi_led_ctrl_task
branch
2 times, most recently
from
dd11fa6 to
63dc3fd
Compare
gemenerik
reviewed
Feb 11, 2025
Slow blink when not connected and then on while sending and off while doing other things. The solution with two bits, one for send and one for done sending is needed since there is no way to wait for a bit to be cleared (except polling). We need to wait with setting the sent bit in the sending thread until we are all done i.e closing any sockets or similar. Otherwise the wait function in the led task will wait indefinitely
Define -1 descriptor as not connected for ease of reading
This is more what it actually signals. I.e do other non-send related things while waiting to send next packet. We need to flag these bits once the socket is actually fully closed for the led task to work correctly
This will lead to the wrong part of the picture being sent when reconnecting a socket
ToveRumar
force-pushed
the
toverumar/wifi_led_ctrl_task
branch
from
6395381 to
39dfcfb
Compare
gemenerik
approved these changes
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While not connected to a client socket the led will blink 2 times/sec.
Once connected it will be on while sending and off while doing anything else like waiting for an image etc