Detect inline header error instead of panicing#7
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to add error handling for malformed inline-mode headers instead of allowing the code to panic. It introduces a new UsbProtocolError variant to the Error enum and adds validation logic to check the received data before processing.
Changes:
- Added
UsbProtocolError(String)variant to theErrorenum for USB protocol violations - Added validation check in
send_inlinefunction to detect malformed inline headers - Captures
answer_sizefromread_bulkoperation for validation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
evoggy
approved these changes
Feb 5, 2026
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| .read_bulk(0x81, &mut answer, Duration::from_secs(1))?; | ||
|
|
||
| // Decode answer | ||
| // The first bye of the answer is the size of the answer |
There was a problem hiding this comment.
Typo in comment: "bye" should be "byte".
Suggested change
| // The first bye of the answer is the size of the answer | |
| // The first byte of the answer is the size of the answer |
gemenerik
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case of malformed inline-mode header, the current implementation panics.
This PR adds a protocolError field to the error type and return it in that case.