Conversation
| def project do | ||
| [ | ||
| app: :bitstyles_phoenix, | ||
| version: "2.3.0", |
There was a problem hiding this comment.
Why 6?
If the goal is to somehow match this to the bitstyles version then that is not needed. One can configure the bitstyles version used (also the default assumption) and there is no need for the versions to align.
There was a problem hiding this comment.
We also usually bump the version as part of the hex release.
| assign(assigns, | ||
| class: class, | ||
| inner_block_class: inner_block_class, | ||
| left_block_class: left_block_class |
There was a problem hiding this comment.
instead of this, I would forward the assigns on the left and inner slots and add the class there. You can find examples for how to do that in the sidebar component or in most of the other places that work with single slots (see assigns_from_single_slot)
| @@ -0,0 +1,166 @@ | |||
| defmodule BitstylesPhoenix.Component.Nav do | |||
There was a problem hiding this comment.
Shall be call it Navbar to match Sidebar and the name in bitsyles?
2 participants
#48
Notes