Merged
Conversation
Member
joelpaulkoch
left a comment
joelpaulkoch
left a comment
There was a problem hiding this comment.
Code looks good to me. The demo app and previews in the docs are broken.
| ### Breaking | ||
| - Update for liveview > 1.0 | ||
| - Stop generating phx-feedback-for in favour of `Phoenix.Component.used_input?` | ||
| - Require Elixir 1.15 |
Member
There was a problem hiding this comment.
Shouldn't we set that in mix.exs then?
Member
Author
There was a problem hiding this comment.
It is kind of implicitly set, since lv 1.0 and above wants it :)
andreasknoepfle
force-pushed
the
update-live-view-to-1.1
branch
from
d547f4c to
9ad1515
Compare
andreasknoepfle
force-pushed
the
update-live-view-to-1.1
branch
from
9ad1515 to
3be836c
Compare
Member
Author
|
I'll try to update one of our projects and see how far i get with this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.