Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/bitdrift_public/fbs/common/v1/common.fbs
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,11 @@ table Field {
// Field value. (Union uses 2 ID slots)
value:Data (id: 2, required);
}

// Flatbuffer representation of a google.protobuf.Timestamp
// The first attempt of this tried to make this a struct for a smaller wire size, but the
// generated Rust code has the wrong alignment. Using a table fixes this.
table Timestamp {
seconds:int64 (id: 0);
nanos:int32 (id: 1);
}
2 changes: 1 addition & 1 deletion src/bitdrift_public/fbs/issue-reporting/v1/report.fbs
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ table FeatureFlag {
// The value of the feature flag, as a string
value:string;
// The time the feature flag was last modified
timestamp:Timestamp;
timestamp:common.v1.Timestamp;
}

table Report {
Expand Down
10 changes: 1 addition & 9 deletions src/bitdrift_public/fbs/logging/v1/buffer_log.fbs
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,6 @@ include "bitdrift_public/fbs/common/v1/common.fbs";

namespace bitdrift_public.fbs.logging.v1;

// Flatbuffer representation of a google.protobuf.Timestamp
// The first attempt of this tried to make this a struct for a smaller wire size, but the
// generated Rust code has the wrong alignment. Using a table fixes this.
table Timestamp {
seconds:int64 (id: 0);
nanos:int32 (id: 1);
}

enum LogType: uint32 {
// Normal logs, from application code.
Normal = 0,
Expand Down Expand Up @@ -60,7 +52,7 @@ table Log {
session_id:string (id: 4);

// The timestamp (in UTC) indicating when this log was recorded.
timestamp:Timestamp (id: 5);
timestamp:common.v1.Timestamp (id: 5);

// The list of action IDs that were triggered by this log line.
workflow_action_ids:[string] (id: 6);
Expand Down
Loading