Make Gradle plugin configurable from build.gradle#460
Merged
Conversation
…tpInstrumentationType, with options PROXY and OVERWRITE.
5e9c376 to
c24690b
Compare
FranAguilera
approved these changes
Jun 25, 2025
Contributor
There was a problem hiding this comment.
before merging, could you add some verification steps on pr description?
Note: This changes the default behavior. Automatic OkHttp instrumentation now defaults to disabled.
Regarding this ^ should we also notify customers/update docs regarding this change?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Gradle plugin can now be configured via the DSL in a client's
build.gradle:This allows clients to use the plugin for upload tasks (
bdUploadand friends) without requiring that their app gets byte code manipulated for OkHttp instrumentation.Configurable values:
automaticOkHttpInstrumentation: Modify the app byte code to auto-instrument all OkHttp requests:true,false(default)okHttpInstrumentationType: How to instrument the calls:OVERWRITE,PROXY(default)Note: This changes the default behavior. Automatic OkHttp instrumentation now defaults to disabled.
These changes will need to be documented for customers.
I used the example app in the
gradledirectory to test these changes:In
platform/jvm:gradle/settings.gradle:gradle/app/build.gradle: