[Android] Minor polishes for crash reporting + Follow internal interface convention#463
Merged
FranAguilera merged 1 commit intomainfrom Jun 26, 2025
Merged
Conversation
FranAguilera
changed the title
FranAguilera
changed the title
📦 APK Size Report
|
kattrali
approved these changes
Jun 26, 2025
FranAguilera
commented
Jun 26, 2025
| Configuration configuration) { | ||
| String userID = UUID.randomUUID().toString(); | ||
| List<FieldProvider> fieldProviders = new ArrayList<>(); | ||
| List<IFieldProvider> fieldProviders = new ArrayList<>(); |
Contributor
Author
There was a problem hiding this comment.
just fyi, this will be a bit annoying to consumers defining their own FieldProviders and may need to do few replaces
Contributor
Author
There was a problem hiding this comment.
Will add another follow up PR for this, there are tons of other places not following the convention
FranAguilera
changed the title
FranAguilera
force-pushed
the
franjam/crash-reporting-feedback
branch
from
509e914 to
bfcacf1
Compare
📦 APK Size Report
|
snowp
approved these changes
Jun 26, 2025
Contributor
snowp
left a comment
snowp
left a comment
There was a problem hiding this comment.
Let's chat a bit about whether we want to rename the other interfaces, not clear to me if breaking the public API is worth it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verified on this session
Context