Skip to content

[Android] Add manufacturer as OOTB field#920

Merged
FranAguilera merged 2 commits intomainfrom
franjam/add-manufacturer
Mar 20, 2026
Merged

[Android] Add manufacturer as OOTB field#920
FranAguilera merged 2 commits intomainfrom
franjam/add-manufacturer

Conversation

@FranAguilera
Copy link
Copy Markdown
Contributor

@FranAguilera FranAguilera commented Mar 20, 2026 •
edited
Loading

What

Part of BIT-7660

Add manufacturer OOTB field for Android.

Verification

Verify _manufacturer emission (example)

Screenshot 2026-03-20 at 15 44 06
  • CHANGELOG.md's "Unreleased" section has been updated, if applicable.

@FranAguilera FranAguilera force-pushed the franjam/add-manufacturer branch from 27f609d to bc3740b Compare March 20, 2026 14:11
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 20, 2026

Size Comparison Report (x86_64)

Metric APK (KB) SO (KB)
Baseline 3406 1280
Current 3406 1280
Difference 0 0

APK size unchanged. SO size unchanged.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 20, 2026 •
edited
Loading

Android Benchmark Results

Device: PR: Emulator - Android SDK built for x86_64 (API 31) | main: Emulator - Android SDK built for x86_64 (API 31)

Note: Benchmarks run on emulator. Results may vary between runs and may differ from physical devices.

Allocations

Test PR main Δ
logHttpNetworkLog50FieldsAndHeadersAndFieldProviders 924 908 +1.8%
logNotMatched10Fields 18 18 0.0%
logNotMatched5000Fields 10 10 0.0%
logNotMatched5Fields 14 15 -6.7%
logNotMatchedNoFields 1 1 0.0%
trackSpansWithFields 140 136 +2.9%
trackSpansWithoutFields 55 56 -1.8%
webViewBridgeBridgeReady 61 64 -4.7%
webViewBridgeCustomLog 66 68 -2.9%
webViewBridgeInvalidJson 38 38 0.0%
webViewBridgeWebVitalCLS 176 180 -2.2%

Timing

Test PR main Δ
logHttpNetworkLog50FieldsAndHeadersAndFieldProviders 241.09 us 381.04 us -36.7%
logNotMatched10Fields 6.01 us 8.35 us -28.0%
logNotMatched5000Fields 2.48 ms 3.45 ms -28.1%
logNotMatched5Fields 4.87 us 5.16 us -5.7%
logNotMatchedNoFields 451 ns 560 ns -19.4%
trackSpansWithFields 493.03 us 808.36 us -39.0%
trackSpansWithoutFields 7.90 us 10.67 us -25.9%
webViewBridgeBridgeReady 7.98 us 12.27 us -35.0%
webViewBridgeCustomLog 8.89 us 13.75 us -35.4%
webViewBridgeInvalidJson 160.29 us 128.58 us +24.7%
webViewBridgeWebVitalCLS 20.55 us 28.77 us -28.6%

murki
murki approved these changes Mar 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@murki murki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment only

@FranAguilera FranAguilera force-pushed the franjam/add-manufacturer branch from bf01bde to 803c666 Compare March 20, 2026 14:30
@FranAguilera FranAguilera reopened this Mar 20, 2026
@FranAguilera FranAguilera enabled auto-merge (squash) March 20, 2026 14:46
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2026
@bitdriftlabs bitdriftlabs unlocked this conversation Mar 20, 2026
@FranAguilera FranAguilera merged commit c098172 into main Mar 20, 2026
30 of 34 checks passed
@FranAguilera FranAguilera deleted the franjam/add-manufacturer branch March 20, 2026 15:35
@github-actions github-actions bot locked and limited conversation to collaborators Mar 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@murki murki murki approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FranAguilera @murki