Closed
Conversation
Contributor
Author
|
Depends on bitdriftlabs/api#74. Leaving in draft as there are likely going to be further API changes as I sort out what we need on the server. |
mattklein123
commented
Sep 9, 2025
mattklein123
commented
Sep 9, 2025
mattklein123
commented
Sep 9, 2025
mattklein123
commented
Sep 10, 2025
mattklein123
force-pushed
the
debug
branch
3 times, most recently
from
8f75735 to
26ef79d
Compare
mattklein123
force-pushed
the
debug
branch
2 times, most recently
from
7aee30f to
130a475
Compare
mattklein123
force-pushed
the
debug
branch
9 times, most recently
from
f9a0c26 to
c0c14bf
Compare
This does not implement "ackless" streaming log uploads. I will do that in a follow up independent change. Signed-off-by: Matt Klein <mklein@bitdrift.io>
snowp
approved these changes
Sep 24, 2025
Comment on lines
+631
to
+632
| // In debug only mode we do not trigger any actions, but we still inject logs so that | ||
| // workflows continue to advance if they depend on the injected logs. |
Contributor
There was a problem hiding this comment.
Agreed that this is required for correctness, though interesting how we do end up having debug workflows have a real impact on the timeline data
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does not implement "ackless" streaming log uploads. I will do that in a follow up independent change.
Fixes BIT-6336