Added install generator #32
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7chris71000
commented
Jun 25, 2021
Gemfile
Outdated
| gemspec | ||
|
|
||
| # lower rails version | ||
| gem "rails", "~> 4.0.0" |
Member
Author
There was a problem hiding this comment.
@caseyli I went lower with rails 4 but can put this to whatever we want
Contributor
There was a problem hiding this comment.
@7chris71000 so I like this functionality, but at the same time I don't want to restrict non-rails programs from using this gem. Would you mind researching how to make this optional? "Like if Rails is installed, run the generator. If Rails isn't installed, don't run it." I think that would be the best option.
7chris71000
commented
Jun 25, 2021
| @@ -0,0 +1,43 @@ | |||
| module Spire | |||
Member
Author
There was a problem hiding this comment.
@caseyli I think this would warrant a version update. Not sure if its x, y, or z in the X.Y.Z version number.
caseyli
requested changes
Oct 8, 2021
Contributor
caseyli
left a comment
caseyli
left a comment
There was a problem hiding this comment.
Left a comment about making Rails an optional requirement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.