Conversation
- Change message format to include reason phrase - Add `reasonPhrase` function to determine the reason phrase for a given HTTP status
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances HttpException to include HTTP reason phrases in error messages, with a fallback mechanism for protocols like HTTP/2 that don't provide them. The change improves error message clarity by transforming messages from "HTTP 403" to "HTTP 403 Forbidden".
- Adds a
reasonPhrase()helper method that extracts the status description or falls back to the default phrase for standard status codes - Updates the exception message format to include both the status code value and its description
- Adds comprehensive test coverage for the new functionality
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/main/kotlin/at/bitfire/dav4jvm/ktor/exception/HttpException.kt | Implements the reasonPhrase() method and updates the message construction to use it |
| src/test/kotlin/at/bitfire/dav4jvm/ktor/exception/HttpExceptionTest.kt | Adds tests for the message format and reasonPhrase() method with both empty and custom descriptions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Works for bitfireAT/davx5-ose#1878, so merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there's no HTTP reason prhase (like for HTTP/2), this PR changes HttpException to fall back to a default reason phrase for the respective status code.
Previously, a HttpException for HTTP/2 403 had the message:
HTTP 403.Now it has
HTTP 403 Forbiddenas one would expect.