Synctools: AndroidEvent companion object moved #1572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Synctools dependency, refactors LocalCalendar instantiation to use Hilt and Dagger Assisted, and introduces Hilt setup in calendar tests.
- Bumps
bitfire-synctoolsversion in Gradle - Converts
LocalCalendarto an assisted-injected class and updates usage - Adds Hilt rules and injects factories in Android tests
- Replaces custom
DateUtilstimezone lookup with ICal4j registry
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| gradle/libs.versions.toml | Updated bitfire-synctools version |
| app/src/main/kotlin/.../LocalCalendarStore.kt | Injected LocalCalendar.Factory and replaced direct calls |
| app/src/main/kotlin/.../LocalCalendar.kt | Converted to @AssistedInject with a Factory interface |
| app/src/main/kotlin/.../DavCollectionRepository.kt | Switched timezone lookup to TimeZoneRegistryFactory |
| app/src/androidTest/.../LocalEventTest.kt | Added Hilt rules, injected factory, removed static setup |
| app/src/androidTest/.../LocalCalendarTest.kt | Added Hilt rules, injected factory, removed static setup |
Comments suppressed due to low confidence (2)
app/src/androidTest/kotlin/at/bitfire/davdroid/resource/LocalEventTest.kt:46
- [nitpick] The field name 'localcalendarFactory' does not follow camelCase convention; consider renaming to 'localCalendarFactory' for consistency.
lateinit var localcalendarFactory: LocalCalendar.Factory
app/src/main/kotlin/at/bitfire/davdroid/repository/DavCollectionRepository.kt:421
- Creating a new TimeZoneRegistry on each call can be expensive; consider caching the registry instance to avoid repeated initialization.
val tzRegistry = TimeZoneRegistryFactory.getInstance().createRegistry()
|
This PR/issue depends on: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates synctools and introduces Hilt for
LocalCalendar.Depends on bitfireAT/synctools#38
TODO: Update commit ID when above PR is merged