Skip to content

LocalTask: Don't subclass DmfsTask #1862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sunkup merged 5 commits into from
Dec 10, 2025
Merged

LocalTask: Don't subclass DmfsTask #1862

sunkup merged 5 commits into from
Dec 10, 2025
+46 −49

Conversation

@sunkup
Copy link
Member

@sunkup sunkup commented Dec 3, 2025 •
edited
Loading

Requires bitfireAT/synctools#155

Purpose

Refactor for better architecture. See bitfireAT/synctools#116 (comment)

Short description

  • Don't subclass DmfsTask anymore.

  • Remove DmfsTaskFactory

  • Update synctools commit ID when ready

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

@sunkup
LocalTask: Don't subclass DmfsTask
546ce57 
Signed-off-by: Sunik Kupfer <kupfer@bitfire.at>
@sunkup sunkup self-assigned this Dec 3, 2025
@sunkup sunkup added the refactoring Internal improvement of existing functions label Dec 3, 2025
This was referenced Dec 3, 2025
Open
Merged
@sunkup
Adapt usages
d37dcd1 
Signed-off-by: Sunik Kupfer <kupfer@bitfire.at>
@ArnyminerZ
Copy link
Member

ArnyminerZ commented Dec 3, 2025

I will review again after the other PR is merged.

@github-project-automation github-project-automation bot moved this from Todo to In Progress in DAVx⁵ Releases Dec 6, 2025
@sunkup sunkup marked this pull request as ready for review December 8, 2025 13:01
@sunkup sunkup requested a review from a team as a code owner December 8, 2025 13:01
@sunkup sunkup requested a review from ArnyminerZ December 8, 2025 13:01
@sunkup sunkup moved this from In Progress to In Review in DAVx⁵ Releases Dec 9, 2025
@github-project-automation github-project-automation bot moved this from In Review to In Progress in DAVx⁵ Releases Dec 10, 2025
@sunkup sunkup requested a review from rfc2822 December 10, 2025 10:44
rfc2822
rfc2822 reviewed Dec 10, 2025
View reviewed changes
Copy link
Member

@rfc2822 rfc2822 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not checked in detail, but feel free to merge if you're convinced that it works.

@sunkup
Copy link
Member Author

sunkup commented Dec 10, 2025 •
edited
Loading

Not checked in detail, but feel free to merge if you're convinced that it works.

I tested task creation and deletion + sync.

@sunkup sunkup merged commit b354bfe into main-ose Dec 10, 2025
6 checks passed
@sunkup sunkup deleted the localtask-dont-subclass-dmfstask branch December 10, 2025 13:37
@github-project-automation github-project-automation bot moved this from In Progress to Done in DAVx⁵ Releases Dec 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rfc2822 rfc2822 rfc2822 left review comments

@ArnyminerZ ArnyminerZ ArnyminerZ approved these changes

Assignees

@sunkup sunkup

Labels

refactoring Internal improvement of existing functions

Projects

DAVx⁵ Releases
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sunkup @ArnyminerZ @rfc2822