Remove dead code for jCard contact processing#2079
Merged
Conversation
* Remove MEDIA_TYPE_JCARD constant * Remove hasJCard flag and related logic * Simplify contact processing to use vCard only * Update processCard to remove jCard parameter
rfc2822
force-pushed
the
1968-drop-unused-jcard-support
branch
from
9b633eb to
0568d17
Compare
rfc2822
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Removes unused jCard handling from CardDAV contact sync, aligning the implementation with the fact that jCard support is effectively disabled and simplifying the sync code to only process vCard payloads.
Changes:
- Removed jCard capability tracking and all jCard-specific branches in contact upload/download handling.
- Simplified
processCardby removing thejCardparameter and always parsing as vCard. - Removed the unused
MEDIA_TYPE_JCARDconstant fromDavUtils.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| core/src/main/kotlin/at/bitfire/davdroid/util/DavUtils.kt | Removes the jCard media type constant now that jCard is no longer used. |
| core/src/main/kotlin/at/bitfire/davdroid/sync/ContactsSyncManager.kt | Deletes jCard capability/branches and simplifies parsing/upload logic to vCard only. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
core/src/main/kotlin/at/bitfire/davdroid/sync/ContactsSyncManager.kt
Outdated
Show resolved
Hide resolved
* Remove unused imports and constants * Simplify contact processing to use vCard only * Update bitfire-synctools dependency
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removal of dead jCard support code which is never actually used because jCard support is commented out:
hasJCardvariable and all logic related to checking for and handling jCard support inContactsSyncManager. [1] [2]processCardmethod and its invocation by removing thejCardparameter and always passingjCard = falsetoContact.fromReader. [1] [2]Codebase cleanup:
MEDIA_TYPE_JCARDconstant fromDavUtils, as it is no longer needed.