Skip to content

PushRegistrationManager: fix repeated sending of requests #2082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rfc2822 merged 2 commits into from
Mar 18, 2026
Merged

PushRegistrationManager: fix repeated sending of requests #2082

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
892ea95
Update PushRegistrationManager to use TextContent for POST requests (…
rfc2822 Mar 17, 2026
02cb3d9
Update bitfire-dav4jvm dependency to a8acbff310
rfc2822 Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions core/src/main/kotlin/at/bitfire/davdroid/push/PushRegistrationManager.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@ import dagger.hilt.android.qualifiers.ApplicationContext
import io.ktor.client.HttpClient
import io.ktor.http.HttpHeaders
import io.ktor.http.Url
import io.ktor.http.content.TextContent
import io.ktor.http.isSuccess
import io.ktor.utils.io.ByteReadChannel
import kotlinx.coroutines.CoroutineDispatcher
import kotlinx.coroutines.sync.Mutex
import kotlinx.coroutines.sync.withLock
Expand Down Expand Up @@ -261,8 +261,7 @@ class PushRegistrationManager @Inject constructor(
serializer.endDocument()

DavCollection(httpClient, collection.url.toKtorUrl()).post(
{ ByteReadChannel(writer.toString()) },
DavResource.MIME_XML_UTF8
TextContent(writer.toString(), DavResource.MIME_XML_UTF8)
) { response ->
if (response.status.isSuccess()) {
// update subscription URL and expiration in DB
Expand Down
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ androidx-test-rules = "1.7.0"
androidx-test-junit = "1.3.0"
androidx-work = "2.11.1"
bitfire-cert4android = "035dd99f7f"
bitfire-dav4jvm = "77c5069f53"
bitfire-dav4jvm = "a8acbff310"
bitfire-synctools = "e9ff9948e3"
compose-accompanist = "0.37.3"
compose-bom = "2026.03.00"
Expand Down