Skip to content

Fix screen orientation change clearing UI state #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArnyminerZ merged 1 commit into from
Sep 27, 2025
+4 −2
Merged

Fix screen orientation change clearing UI state #725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/src/main/java/at/bitfire/icsdroid/model/SubscriptionSettingsUseCase.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,7 @@ import at.bitfire.icsdroid.HttpUtils
import at.bitfire.icsdroid.db.entity.Credential
import at.bitfire.icsdroid.db.entity.Subscription
import javax.inject.Inject
import javax.inject.Singleton

@Singleton
class SubscriptionSettingsUseCase @Inject constructor() {
data class UiState(
val url: String? = null,
Expand All @@ -35,6 +33,8 @@ class SubscriptionSettingsUseCase @Inject constructor() {
val validUrlInput: Boolean = url?.let { url ->
HttpUtils.acceptedProtocol(url.toUri())
} ?: false

fun isInitialized() = url != null || title != null || color != null
}

var uiState by mutableStateOf(UiState())
Expand Down
2 changes: 2 additions & 0 deletions app/src/main/java/at/bitfire/icsdroid/ui/screen/AddSubscriptionScreen.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,8 @@ fun AddSubscriptionScreen(
}

LaunchedEffect(title, color, url) {
if (model.subscriptionSettingsUseCase.uiState.isInitialized())
return@LaunchedEffect
model.subscriptionSettingsUseCase.setInitialValues(title, color, url)

if (url != null) {
Expand Down