Adding events: avoid misleading "Dropping exceptions" warning #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the logging accuracy in the AndroidRecurringCalendar.cleanUp() function by only displaying a warning message when there are actually exceptions to drop, rather than always showing the warning when the conditions are met.
Key Changes:
- Added a conditional check
if (original.exceptions.isNotEmpty())before logging the "Dropping exceptions" warning - Prevents misleading warning messages from being logged when no exceptions exist
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rfc2822
deleted the
151-misleading-dropping-exceptions-warning-although-there-are-no-exceptions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only print warning when there actually are exceptions