Skip to content

Additions needed for updating ICSx⁵ #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
sunkup wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Additions needed for updating ICSx⁵ #169

sunkup wants to merge 3 commits into from

Conversation

@sunkup
Copy link
Member

@sunkup sunkup commented Jan 13, 2026 •
edited
Loading

Should stay open and receive selective merges from master, step-by-step for ICSx⁵ to catch up. ICSx⁵ will reference commits from this PRs branch until fully up-to-date.

Reviews should be made together with the synctools version increasing PRs in ICSx⁵.

Changes:

@sunkup sunkup self-assigned this Jan 13, 2026
@sunkup sunkup added the refactoring Quality improvement of existing functions label Jan 13, 2026
@sunkup sunkup linked an issue Jan 13, 2026 that may be closed by this pull request
LocalEvent: Provide all fields for ICSx⁵ #168
Closed
@sunkup sunkup removed a link to an issue Jan 13, 2026
LocalEvent: Provide all fields for ICSx⁵ #168
Closed
@sunkup sunkup mentioned this pull request Jan 13, 2026
Merged
4 tasks
@sunkup sunkup requested a review from ArnyminerZ January 13, 2026 14:55
ArnyminerZ
ArnyminerZ approved these changes Jan 13, 2026
View reviewed changes
Copy link
Member

@ArnyminerZ ArnyminerZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@rfc2822 @sunkup
Explicit PRODID handling (#19)
4154d36 
* Add `PRODID` parameter to `write` methods

* Add explicit product ID to vCard generation

* Rename lib project in gradle

* Fix tests
@sunkup sunkup mentioned this pull request Jan 14, 2026
Open
@rfc2822 @sunkup
Remove possibility to subclass AndroidEvent (#20)
9db5cb5 
* - Move features from LocalEvent to AndroidEvent
- Remove AndroidEventFactory because it's not meant to be subclassed anymore

* AndroidEvent: use private methods

* Move tests

* Move InitCalendarProviderRule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArnyminerZ ArnyminerZ ArnyminerZ approved these changes

Assignees

@sunkup sunkup

Labels

refactoring Quality improvement of existing functions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sunkup @ArnyminerZ @rfc2822